Henry Schreiner

Results 2521 comments of Henry Schreiner

I'd prefer to keep this inline with scikit-build-core, where it will never convert a string to a list because you "appended" them. We also don't support "append" on string-only items;...

`inherit` shipped about a week ago. I think it's fine if we handle `environment` and `config-settings` differently based on how they are used. I'd consider `config-settings` the correct behavior and...

This example is not helpful if you have a CMakeLists.txt. You should look at https://github.com/pybind/scikit_build_example, which is much better, or https://github.com/pybind/python_example, which is probably what you based your `setup.py` on....

Oh, I did think you were using M1 for some reason... Going to guess you have separate CMake and setuptools builds; it's better to use scikit-build-core, but I still have...

You should use Plumbum paths here, something like: `ls["-arth", local.env.home / 'Downloads' // '*.sgf']`

The double forward slash tells it to join *and* glob; that is, expand the star. I think there's a pathlib style `.glob()` method that does the same thing. Your other...

I think we'd need support in pybind11 for this (could be wrong, but I think so). That would mean it needs a CAPI interface, which I would guess it has?

Ah, yeah, you probably have to use boost-histogram's cast system to go from C++ class to the correct Python class. I can look (hopefully by end of day or tomorrow,...

I still need to review this and make it work on callables.

Few quick tips: No need to wrap `Hist.new..Double()` in `Hist()`, it's already a Hist! :) You can also use `np.random.normal(loc=1, size=100_000)` instead of `np.random.normal(size=100_000) + np.ones(100_000)` to save an addition...