Henry Schreiner

Results 2521 comments of Henry Schreiner

How would this interact with parametrization? I could see it potentially being very useful to allow a parametrized test to reuse the same environment, but some cases that would be...

Does `{venv_location}` contain `pyvenv.cfg` on Windows? I'm not sure it does, for at least one of venv/virtualenv.

That's what I thought, but some of the tests are disabled on Windows looking for it (and virutalenv < 20 didn't add one it seems from comments).

What about trying https://github.com/astral-sh/uv/issues/3439#issuecomment-2102159802? This will block https://github.com/pypa/manylinux/pull/1614 (though reverting for now is the correct short term fix).

This should be really easy to test later, I just need to use my AS machine and try it.

Yes, it works: ```bash pipx run wheel tags --platform-tag +manylinux_2_17_aarch64.manylinux2014_aarch64 uv-0.1.43-py3-none-musllinux_1_1_aarch64.whl ``` And the following Dockerfile: ```Dockerfile ARG PYTHON_VERSION=3.11 FROM python:${PYTHON_VERSION}-slim as base RUN apt-get update RUN apt-get install -y...

It isn't doing a full checkout. With the shallow checkout, it's not able to figure out its own version. If we have to give up svn versioning, we could do...

Hmm, psf/black uses the same versioning method. Maybe it's not usually a problem because usually you don't check the version with a dependency?

Pre-commit recently changed its checkout method to make it faster, it could have broken this. It's also possible that it rarely matters, since normally you don't have pinning between the...

I think we need to make a mirror. I don't see a way to install `[cli]` here (`additional_dependenices` won't work, since users have to override it). There's also the same...