Henry Schreiner

Results 2521 comments of Henry Schreiner

Okay, I'll give up until more can be understood. @volkm is patching pybind11 at https://github.com/moves-rwth/stormpy/tree/6c983bc9395646ccbe04cbf7238d6f5aeb922946/resources, so I'd say the answer to "is it needed" is yes. Personally, I'd be fine...

@volkm I really don't see how this could be leaking, and I'd really like to know how it does leak. Do you have the full error message, not just the...

This would also fix https://github.com/pybind/pybind11/issues/5072, FYI.

``` FAILED: tests/CMakeFiles/pybind11_tests.dir/test_custom_type_casters.cpp.o /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DPYBIND11_TEST_BOOST -DPYBIND11_TEST_EIGEN -Dpybind11_tests_EXPORTS -I/Users/henryschreiner/git/software/pybind11/include -isystem /usr/local/opt/[email protected]/Frameworks/Python.framework/Versions/3.11/include/python3.11 -isystem /Users/henryschreiner/git/software/pybind11/.nox/tests-3-11/tmp/_deps/eigen-src -isystem /usr/local/include -Os -DNDEBUG -std=gnu++11 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk -mmacosx-version-min=14.2 -fPIC -fvisibility=hidden -Wall -Wextra -Wconversion -Wcast-qual -Wdeprecated -Wundef -Wnon-virtual-dtor -Werror...

When you know the namespace and don't want ADL, the general solution is to fully qualify it. Tricks are out there for the other direction, but if you know the...

I'm okay to add those, though I wasn't able to get them to trigger easily. I suspect a few other of our functions are susceptible, but `concat` just happens to...

Ah, the reason the `tuple[]` one can't trigger is that it's doing ADL on the argument, which is `std::tuple`. So if `std::concat` was ever added, that would break. In fact,...

Any ETA on the RC? That would make it easier to test with. I really wish our NumPy support was pulled out into it's own module, that would have allowed...

I basically do that (with a single generated file instead of a zip) here: https://github.com/CLIUtils/CLI11/blob/main/.github/workflows/build.yml

I don't understand how this could be adding errors on 3.12. No code changes that I see. 🤷