pybind11 icon indicating copy to clipboard operation
pybind11 copied to clipboard

tests: run on pyodide

Open henryiii opened this issue 2 years ago • 5 comments

Adding WebAssembly testing on Pyodide.

Description

Suggested changelog entry:

* Adding WASM testing.

henryiii avatar Jul 14 '23 15:07 henryiii

Do you already understand the Python 3.12 failures? When I saw them previously I decided to trigger a CI run with master as-is (#3939) and I don't see any errors there.

rwgk avatar Jul 14 '23 20:07 rwgk

I don't understand how this could be adding errors on 3.12. No code changes that I see. 🤷

henryiii avatar Jul 20 '23 20:07 henryiii

I don't understand how this could be adding errors on 3.12. No code changes that I see. 🤷

My best guess: some change in the environment triggers a latent bug in 3.12 (or how we use 3.12).

Could tests/pyproject.toml have something to do with it?

rwgk avatar Jul 20 '23 20:07 rwgk

Importing pytest or sys (probably pytest) inside test_embed causes Python 3.12 to segfault. b9b391c9 fixed the issues - we don't really need to do it, since we are avoiding these anyway on Pyodide. But why? How?

henryiii avatar Jun 26 '24 20:06 henryiii

And the interesting question: Should we add -fexceptions when building on emscripten in our CMake helpers? Is there a reason someone wouldn't want them (using them, which we do a lot, would cause crashes). @hoodmane?

henryiii avatar Jun 26 '24 20:06 henryiii