Eugene Mironov

Results 16 comments of Eugene Mironov

We were discussing it, but I think that nobody started developing it. It should be pretty - just like 2/3 lines of code. The only important note is that during...

I have checked more or less the code, added comments. Also I have provided a fixes for some comments - https://github.com/huggingface/lerobot/pull/1441

Some tests are missed, but it's one the way - Some tests are missed, but it's on the way - https://github.com/huggingface/lerobot/pull/1074. Networking part will be after that.

I think that https://github.com/michel-aractingi/lerobot-hilserl-guide should be mentioned somewhere in the README.md or in some docs. Whenever the current PR is merged - it will be impossible to find the guide...

Except comments that I already have provided changes look good. I also would like to add several points: 1. Security for networking part. Probably that shouldn't be part of the...

> Nice! Last thing to figure out with @aliberts: where to put files in `scripts/server`? probably in `lerobot/rl` folder with (maybe) entry points for scripts in `scripts`. @Cadene @AdilZouitine @aliberts...

> > Nice! Last thing to figure out with @aliberts: where to put files in `scripts/server`? probably in `lerobot/rl` folder with (maybe) entry points for scripts in `scripts`. > >...

> > > Nice! Last thing to figure out with @aliberts: where to put files in `scripts/server`? probably in `lerobot/rl` folder with (maybe) entry points for scripts in `scripts`. >...

> Given the size of this PR and our tight deadline for merging into `main`, I would address any findings worth discussing incrementally via follow-up tickets/PRs. The development team of...