heinrich5991

Results 65 issues of heinrich5991

Linux defaults to `setsockopt(IPV6_V6ONLY)` being false, Windows has it true by default. The masterserver relies on that flag being unset, i.e. that the socket works for both IPv4 and IPv6....

bug
Windows
masterserver

Still missing: - [ ] timeout protection - [x] works on computers other than my own? - [ ] works on windows? - [ ] works for cross-compiling - [...

[**Summary by UnlucksMcGee**](https://github.com/ddnet/ddnet/issues/3411#issuecomment-1534189301) (thanks a lot!)

meta-discussion

CC https://github.com/heinrich5991/libtw2/issues/93 CC @Zwelf The type `NetTick` seems wrong, should probably be a NetInt. https://github.com/teeworlds/teeworlds/blob/a1911c8f7d8458fb4076ef8e7651e8ef5e91ab3e/src/game/gamecore.cpp#L294-L295 https://github.com/teeworlds/teeworlds/blob/a1911c8f7d8458fb4076ef8e7651e8ef5e91ab3e/datasrc/network.py#L170

This would make the function `str_from_int` unnecessary, at least user-facing. Advantage: User doesn't have to care about `str_from_int`/`str_format` distinction. Disadvantage: We're adding some template programming to `system.h`, potentially slowing all...

This gives a degree of freedom, making diffs worse. A script should be added and sorting should be checked in CI.

CI
scripts
localization

Masterserver parsing is supposed to be strict and not allow any deviation from the protocol.

cleanup
engine

Message isn't flushed, so there's little point in sending it at all: https://github.com/ddnet/ddnet/blob/1460081d8c1f7f5873ca48f94dad0c7030434fc2/src/engine/client/client.cpp#L249

bug
client

They can be handled via the map configs already. Mostly needs updates in DDNet's infrastructure. CC #430

server
cleanup

Do we want to use a web app for managing translations? It might make the barrier to entry a little bit lower since you don't have to interact with github...

meta-discussion
localization