Hennadii Stepanov

Results 959 comments of Hennadii Stepanov
trafficstars

> Is it correct that the first commit is the actual fix and the second commit is just a refactor? The second commit is the fix, as the current implementation...

re: https://github.com/bitcoin/bitcoin/pull/31000#issuecomment-2437357680 > It would be good if ctest/Windows actually printed the exception and error message instead of silently hiding it. I'm not aware of the specific case discussed above,...

While introducing a new `wallet/util_spend.h` header, it seems reasonable to address all related IWYU warnings, no?

Concept ACK. > Additionally, this PR moves the `CreatedTransactionResult` struct into its own file. This part of the PR description seems no longer relevant. > Thanks for the review ryanofsky!...

> > Would be good to register this new type into the Qt's meta-object system. Look at the RegisterMetaTypes() function on src/qt/bitcoin.cpp. > > Good point. It's used in at...

@kristapsk > If you use both mainnet and testnet3 on the same machine, in default configuration `testnet3` directory is under mainnet Bitcoin datadir. If you have also testnet wallet there...

For the reference, Chimera Linux is not listed in Qt 6.7 [Supported Platforms](https://doc.qt.io/archives/qt-6.7/supported-platforms.html).

@achow101 Could you please add https://github.com/bitcoin-core/gui/pull/835 as well?