Hennadii Stepanov
Hennadii Stepanov
> Did you pass `-DJOBS=$( nproc )`? I did. Why?
> [#341 (comment)](https://github.com/hebasto/bitcoin/issues/341#issuecomment-2310803071) claims that clang is working. > > However, I can not get it to work with the same commands (there is no html generated). Can you double...
> I tried to use GCC (on the autotools branch), but it had many problems: > > * `__gcov_reset` (from https://github.com/bitcoin/bitcoin/pull/30156/files) doesn't seem to be doing anything. See for example...
@maflcko Can you re-confirm please that you cannot generate a coverage report on Ubuntu 24.10 using [clang 18.0](https://packages.ubuntu.com/oracular/clang) and [lcov 2.1](https://packages.ubuntu.com/oracular/lcov)?
From [Professional CMake: A Practical Guide 19th Edition](https://discourse.cmake.org/t/professional-cmake-a-practical-guide-19th-edition/11460): > In practice, using gcov-based coverage data with clang can be challenging. Due to the way paths are written to the coverage...
> _If_ we come to the conclusion that most of our testing should align with what Core uses, then the difference of 86 vs 22 (as some kind of algorithmic...
> In the specific case of ecmult_gen, this means we should just increase the default to 86 kib. See https://github.com/bitcoin-core/secp256k1/pull/1564.
Recent merge commits, for example, https://github.com/bitcoin/bitcoin/commit/141115a0604001b8cce848804798dc174770a994, point at [bitcoin-core-merge-script](https://github.com/bitcoin-core-merge-script) GitHub user. Is it required?
Concept ACK, with the hope that build system changes will be picked up (perhaps in a follow-up).
Why the first commit "net: Ensure CNode.cleanSubVer is always assigned before nVersion" is needed?