Heath Stewart
Heath Stewart
OpenAPI Hub has been too unreliable, so I wanted to provide a script that would automate at least most of the work of creating a new API version for an...
I don't see a baseline commit, so it's hard to know exactly what's new in this api-version. I also see several RPs in this review. Do you have any documentation...
Also, from the meeting, I see the confusion: you're treating each group of endpoints as a separate resource provider, which is atypical and confusing. You can put things in separate...
@JeffreyRichter I don't have time to re-review so if you guys are happy with it, go ahead and merge. I don't want to sign off since I didn't review, but...
To be clear, I'm only approving to unblock. Seems the option to dismiss my review is missing from this PR; though, I've seen it before. I just don't have time...
Based on the [APIView diff](https://apiview.dev/Assemblies/Review/37fdba396e0b47ccb1abdee047f985b9?revisionId=71b011f0d8c94646862e51c2604ba06b&diffOnly=False&doc=False&diffRevisionId=72ae459fb9ec4b6da898c8ddfa038c12) from the previous preview, this looks fine. Were the previews reviews? Looking at the [APIView diff](https://apiview.dev/Assemblies/Review/37fdba396e0b47ccb1abdee047f985b9?revisionId=71b011f0d8c94646862e51c2604ba06b&diffOnly=False&doc=False&diffRevisionId=829e476dafbd4d218f70432827514d5a) from the last GA, there are quite a few...
I see @mikekistler [previously approved](https://github.com/Azure/azure-rest-api-specs/pull/24291#event-9736211988) the `uri` breaking changes, so I'm applying the appropriate label.
APIView looks fine, so approving.
You need to fix the ModelValidation errors as well.
Sorry that got closed. Seems I hit some key sequence accidentally that closes GitHub issues. 😬