Heath Stewart

Results 419 comments of Heath Stewart

Based on https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda#backward-compatibility, any terminal that supports OSC sequences should at least display the link text, if any, or is considered buggy. Apart from having to maintain some sort of...

@muesli if no one else wants to submit a PR, what do you think of my [suggestion](https://github.com/charmbracelet/glamour/issues/114#issuecomment-854367508)? It wouldn't require a terminfo or termcap database for non-*nix systems, both of...

Happy to, but in testing this out, I found it would otherwise force passing something like `--filter *Benchmarks*` (or whatever non-default benchmark name was used) so I'm trying to find...

Somewhat oddly, `BenchmarkSwitcher.RunAll` doesn't take `args`. This almost seems to imply that `Run(args)` was meant mainly to filter benchmarks, while seemingly all possible options of the old global tool can...

Seems the main culprit is: https://github.com/dotnet/BenchmarkDotNet/blob/b4e2b69cbe5065a0315e8ff62035db2694db4686/src/BenchmarkDotNet/Running/BenchmarkSwitcher.cs#L108 If types were provided explicitly like in the following example that could be used in the template instead, perhaps, by default, the user shouldn't...

To clarify, if that was the intent, I can go ahead and fix that problem in the `BenchmarkSwitcher` as well. I just wanted to make sure that was indeed the...

Perhaps it goes without saying, but I think we should be explicit about guidance for acronyms like "LUIS", that they should be all lowercase like "luis".

I'll see if I can find the notes, but I thought we already talked about this: that enum values should be PascalCase and case-insensitive matches. @markweitzel do you recall this?...

A few common ones come to mind re: dates e.g., * `createdOn` * `updatedOn` * `notBefore` * `expiresOn` (often `notAfter`) * `confidence`/`confidenceThreshold` (drop "Score") Some of these were discussed at...

I would at least extend the samples - your `?` in the block comment - to include "days, months, years" to solve the anniversary problem. Rotating keys every 3 months...