Heath Stewart

Results 419 comments of Heath Stewart

The only breaking changes I see are an old one that was intentional and previously approved i.e., adding `type` (of either "string" or "object" as needed) to satisfy some other...

The breaking changes around adding `type: string` and `type: object` was previously approved, nor consequential to our code generation that hasn't already been solved.

From @bidisha-c, this is needed for the new api-version coming up. I think it would be easier to close the associated PR and start anew, since new files need to...

@JeffreyRichter @mikekistler this is aligning the swagger to match the service - or at least what the service did do and will soon again. Can you approve?

> Lets Add CP to it, so we are consistent. @jlichwa is that actually what CP returns though? In a previous conversation, you indicated that DP was likely changed to...

CP should not be changed. It's a breaking change. They may be inconsistent, but that is how the service behavior shipped and should be retained. Only the swaggers should be...

Talking offline, I now understand that both CP and DP were returning Pascal case, so this is fixing the swagger for both since the service behavior for both is being...

@weshaggard @maririos do you know who owns the failing azure-powershell? Looking at the results, I'm not entirely sure on the problem but wonder if it's related to the intentional breaking...

@dingmeng-xue do you know what exactly is causing [these errors](https://github.com/Azure/azure-rest-api-specs/pull/24475#issuecomment-1599475754)? I worry it's the case change but, if that was the case - if Az.KeyVault was case-sensitive for these values...

To note, I think this is otherwise good to go but we need to better understand the impact to Az.KeyVault. /cc @dolauli @isra-fel