Michael Niklas

Results 188 comments of Michael Niklas
trafficstars

I have now removed the requirement to implement a `transpose` method as only the adapter classes implemented it but not the backend classes (it required two `# type:ignore`s...). Maybe it...

All plot methods use the **kwargs to pass additional options to matplotlib.

> I'm running into an issue with variables without the core dimensions. Would it be better to do a work around in cumsum or in apply_unfunc like you mentioned in...

That is weird, with `from __future__ import annotations` this should work. Actually the pyupgrade pre-commit hook should even replace the typing versions by built-in versions.

Could you add an additional mypy workflow to test this behavior? See https://github.com/pydata/xarray/issues/6962#issuecomment-1277287183

When I run locally `mypy --python-version 3.8` i get more errors. Maybe merge current main and let's see what new issues emerge.

@dcherian on a different issue: can we prevent that the auto labeler removes manually added labels?

Seems that pyupgrade does not update `tuple` -> `Tuple` inside of `Union`, which is exactly what caused these problems. Looks good to me now 👍

Seems like dasks typing is also not compatible with python 3.8, haha

I cannot reproduce the mypy error locally. Does this break for someone else?