Michael Niklas

Results 193 comments of Michael Niklas
trafficstars

Ok seems @Illviljan and myself were a few month off xD https://github.com/pydata/xarray/pull/6821#issuecomment-1193378283. Nvmd then :)

> It's this table https://numpy.org/neps/nep-0029-deprecation_policy.html#drop-schedule : > `On Jan 31, 2023 drop support for NumPy 1.20 (initially released on Jan 31, 2021)` We are dropping 1.19 here, where this table...

Ok I think I found my misunderstanding. Instead of dropping versions older than 18 month we want the oldest supported version to be at least 18 month old.

Anyone know why min all deps fails? As far as I can tell the only requirement of netCDF is python 3.8?

I got rid of the complete npcompat module. Not sure if you actually want to keep it around in case new incompatibilities arise? But I guess we can always add...

@dcherian I see that you were working on this the last time. Do you have any idea why mamba fails to resolve the environment (for min-all-deps)? With netcdf4=1.5.3 it fails...

> sorry! trying to fix this in conda-forge/flox-feedstock#22 Thanks! Do we have to clear some micromamba cache for this to work immediately or should it just work after some days?

Is there a reason why the minimum versions are not in the additional requirements in setup.cfg?

We usually only fix the minor version, in this case `cdms2=3.1`. But it seems to work now... LGTM!

Noble effort, but I think we will have to wait until https://github.com/python/mypy/issues/12846 is solved, otherwise users will get false positives...