Michael Niklas

Results 195 comments of Michael Niklas

wait.... did mypy 0.981 change the behavior of overloads with None and Hashable? I now get errors for ```python from typing import Hashable @overload def x(a: Hashable) -> Hashable: ......

So finally I have decided to properly deprecate positional arguments since I think many users are still using them (even many tests where using them...)

> Excellent! Should we hit the green button? Don't know if @Illviljan wants to merge his PR first or prefers to solve the merge conflicts himself :P

That was quite a merge, haha.... @Illviljan I had to undo some of your work, it just did not work well with static typing. Hopefully you are not too sad...

Next time I should split such a PR into smaller ones, haha. Anyone ready for a final review?

Ok, good question. I have to look into it. Anyway, you should use kwargs for x and y as well :) Also, we should definitely test this haha

For me this code works? Besides from too few distance between the subplots such that the z-labels are on top of the neighboring plot. And the y and z axis...

I get much more overlap than you! Why is that? Windows again? ![test](https://user-images.githubusercontent.com/43316012/195672966-a636e77b-22d2-4e1b-a708-030389ba2fac.png) I don't necessarily agree about y-axis pointing upwards, I think that is confusing. But I let people...

Yes, sequence sounds right if the order matters. Usually we do not use `len(input)` or `x in input` though. Maybe reversible container or something else exists? A bit unfortunate that...

> We can build a list if we need a len? Or IIRC there is a `Sized` type — a `Set` but not an `Iterable`. We already do that. We...