Michael Niklas

Results 193 comments of Michael Niklas

I have to admit, I am not too familiar with the internals of custom array classes and `__array_ufunc__`. But even if I go through all the effort to add the...

The two relevant kwargs to set to reproduce the matplotlib plotting are: `yincrease=False` and `interpolation=None` I don't know why the default of xarray is `interpolation="nearest"`...

I have created https://discuss.python.org/t/make-type-hints-for-eq-of-primitives-less-strict/34240 Feel free to continue discussing over there :)

Still happening with mypy 0.960 :( Although, now without "*" in the revealed types.

I have simplified this approach, now you define directly the format string instead of the brackets. Much simpler and more flexible. If you decide to scrap this, also fine by...

Is the current approach still too specific? I'm fine with closing this.

I don't see a reason why we could not simply remove this check (I didn't look at the code, possibly requires some refactoring). This would solve the issue at hand...

I think it's a good idea. But should probably have the same arguments and workings as `drop_vars` and others. If you want to control the behavior of dropping attrs from...

For the operators we will run into the following issue: Currently `Variable + DataArray` will return a `DataArray` because Variable will return `NotImplemented` and then python calls `DataArray.__radd__`. This is...

I can have a look at it :) By the way: do we want to get rid of the `fastpath` argument to the `__init__` and replace it with a custom...