Hunter Damron

Results 26 comments of Hunter Damron

Also, I'm probably not working with `replacements` and `pending` properly in [`replace()`](https://github.com/jyn514/saltwater/blob/10019b/src/lex/replace.rs#L157).

I'm assuming you'll want more tests...

Related to C11 standard [6.7.2.1p3](http://port70.net/~nsz/c/c11/n1570.html#6.7.2.1p3) > A structure or union shall not contain a member with incomplete or function type (hence, a structure shall not contain an instance of itself,...

Standard [6.7.2.3p4](http://port70.net/~nsz/c/c11/n1570.html#6.7.2.3p4) > All declarations of structure, union, or enumerated types that have the same scope and use the same tag declare the same type. Irrespective of whether there is...

Is there already a notion of complete vs incomplete types in rcc or no?

I'm getting a borrow of moved memory error if I rearrange the two blocks because `symbol` is being used in the `match` block. It seems the `members.push(symbol)` should be separate...

Reordering doesn't work because incomplete types are not yet implemented for struct/union. As much as I'd like to pursue this further, I think this will require modifying [`TYPES`](https://github.com/jyn514/rcc/blob/a388f00f/src/data/types.rs#L29) to have...

I think unit tests would be preferred where possible (and I think they would be since `parse_args` is its own function). But having some runner tests of that sort would...

Also, a lot of the flags require external files which may be complicated for the runner tests (not sure).

Confirmed: this originated in #456 (specifically commit 3d2d038 but it didn't compile from 34e5ad2..8ef29cf and stringify was not implemented in ..0ef39e4).