Eliza Weisman

Results 530 comments of Eliza Weisman

> On the one hand it seems like we could actually implement `Valuable` in terms of the underlying bytes as `Listable`, This also makes me wonder a bit if there...

`tracing` 0.1 supports `f64`s as typed values; if we're going to do a wholesale replacement of `tracing`'s value system with `valuable` in `tracing` 0.2, we should probably add support for...

> > we should probably add support for floats as primitive values. > > I believe floats are already supported. > > https://github.com/tokio-rs/valuable/blob/acd1a7ea5954a68f39ddbff2231bf64243b70333/valuable/src/value.rs#L137-L157 whoops, it looks like i can't read!...

I don't _think_ this needs to be a blocker for 0.1; we can always add new primitives in backwards-compatible changes.

AFAICT, the CRD reference docs are not automatically included in the website. See https://github.com/linkerd/website/blob/alpeb/2.12/linkerd.io/content/2.12/reference/authorization-policy.md, where the `Server` and `ServerAuthorization` are manually included in the markdown file. My guess is that...

It occurred to me that we could also add a provision for configuring backoffs associated with retries using the existing `ExponentialBackoff` messages, although that wasn't discussed in the RFC proposing...

Whoops, thanks for the report. We should fix that!

@seanmonstar ![screen shot 2018-09-07 at 3 33 16 pm](https://user-images.githubusercontent.com/2796466/45245943-84b2ca80-b2b3-11e8-8d12-40b10bfa9708.png) Maybe it's time? (cc @carllerche)

What about referring to [docs.rs](https://docs.rs/) instead?

@seanmonstar that's fair, good point.