tower-h2 icon indicating copy to clipboard operation
tower-h2 copied to clipboard
verified publisher icon tower-rs

Error handling

Open hawkw opened this issue 7 years ago • 3 comments

Places where errors are discarded:

  • [ ] client::Background::poll: https://github.com/tower-rs/tower-h2/blob/e209b835d3815fb1dc4175ff4d95069f2d0b4822/src/client/background.rs#L55
  • [ ] Flush::poll: https://github.com/tower-rs/tower-h2/blob/e209b835d3815fb1dc4175ff4d95069f2d0b4822/src/flush.rs#L171
  • [ ] server::Background::poll: https://github.com/tower-rs/tower-h2/blob/e209b835d3815fb1dc4175ff4d95069f2d0b4822/src/server/mod.rs#L454-L455

Loss of specificity:

  • [ ] server::Background::poll: error always sends an INTERNAL_ERROR: https://github.com/tower-rs/tower-h2/blob/e209b835d3815fb1dc4175ff4d95069f2d0b4822/src/server/mod.rs#L430-L432

(N.B. that I'm still adding to the list)

hawkw avatar Sep 07 '18 21:09 hawkw

Something to consider is that hyper provides most (all?) of the functionality of tower-h2, we may be able to just switch to it entirely in Linkerd2.

seanmonstar avatar Sep 07 '18 22:09 seanmonstar

@seanmonstar screen shot 2018-09-07 at 3 33 16 pm Maybe it's time? (cc @carllerche)

hawkw avatar Sep 07 '18 22:09 hawkw

@seanmonstar I mean, my hope was that the tower-h2 impl was available to use standalone and hyper used it to provide HTTP/2.0 support. I'm not sure how possible that is.

carllerche avatar Sep 07 '18 23:09 carllerche