Ashhar Hasan

Results 251 comments of Ashhar Hasan

I have similar issues, you can reproduce this on an M3 Mac with: ``` git clone https://github.com/trinodb/trino ./core/docker/build.sh -r 466 ``` This will eventually fail with: ``` #16 30.13 Running...

As far as I understand even if the token is refreshed any already running queries would still fail? If so we should make it clear once we add the functionality...

And also once we have this implemented we can think of changing https://github.com/trinodb/trino-python-client/pull/462 to align with whatever "interface" we come up with for this issue.

I just noticed I forgot to tag you @sugibuchi. Wanted to check if you're still willing to send a PR for this since it seems you have some ideas already.

We should force HTTP/1.1 in the Python client same as the JDBC/Trino-CLI. see https://github.com/trinodb/trino/pull/22171 for equivalent change in CLI/JDBC. cc: @damian3031

This turns out to be a Jetty issue. So https://github.com/trinodb/trino/issues/23237 should help. In Python there's no HTTP/2 support in the requests library so there's no way it upgrades connections anyway....

Closing since this duplicates https://github.com/trinodb/trino/issues/18387 and more discussion is already there.

Thanks for the explanation. This makes sense (and it's unexpected that writes to stdout will get bufferred). It looks like a simple change, are you willing to submit a PR...

Correct, if you want to proxy authentication or TLS then `http-server.process-forwarded` + making sure the proxy passes `X-Forwarded-*` headers is the solution. Closing, feel free to re-open if needed.

We can focus on implementing "Set some boolean so that calling any method of the cursor leads to Error" for `cursor.close()` as that's the main thing we are missing. Transactions...