Ashhar Hasan

Results 251 comments of Ashhar Hasan

There is related work ongoing in https://github.com/trinodb/trino/issues/15921 - without that while you can have dynamic catalogs one of the most important connectors - Hive (and Iceberg) won't be able to...

@dain A question, the `CatalogVersion` javadoc says: ``` /** * Version of a catalog. The string maybe compared lexicographically using ASCII, and to determine which catalog version is newer. */...

In an offline discussion we realised that the `CatalogVersion` contract doesn't need to define lexicographic ordering because in current implementation the engine or catalog store never needs a sorting of...

@JamesRTaylor most of it is regarding untested code (pushdown for text types) and decimal predicates A quick grep gives me: ``` $ grep -R -n -E 'TODO.*7100' plugin/trino-clickhouse plugin/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java:409: //...

@mathsteam Tests will need to be added to verify the effect and fix any failures accordingly. See `TestPostgreSqlTypeMapping` and `PostgreSqlConnectorTest#testPredicatePushdown` as some examples of what to add to ClickHouse.

It's a logical unsafety because the rollback action is populated based on the actions a single query takes. You cannot apply rollbackAction set by one query as a compensation action...

As long as the query can compute results fast enough the results are streamed back to the client. So e.g. `SELECT * FROM my_large_table` does stream results perfectly since rows...

this time both `TestIcebergMinioOrcConnectorTest.testOptimizeTimePartitionedTable` and `TestIcebergMinioOrcConnectorTest.testIfRemoveOrphanFilesCleansUnnecessaryDataFilesInPartitionedTable` failed.

There is no issue here. All of the properties on that page have their defaults documented. for `task.concurrency` it might be confusing because the default value is not a constant-...