Erik Härkönen

Bug in preprocessing code

1

The preprocessing code contains the [following lines](https://github.com/yzxing87/Invertible-ISP/blob/main/data/data_preprocess.py#L50): ``` if camera_name == 'Canon EOD 5D': raw_img = np.maximum(raw_img - 127.0, 0) ``` The string literal is incorrect, it should be `Canon_EOS_5D`...

The render function in RenderCore_Minimal contains an [incorrect call](https://github.com/jbikker/lighthouse2/blob/e61e65444d8ed3074775003f7aa7d60cb0d4792e/lib/RenderCore_Minimal/rendercore.cpp#L77) to glTexSubImage2D: ``` glTexSubImage2D( GL_TEXTURE_2D, 0, GL_RGBA, screen->width, screen->height, 0, GL_RGBA, GL_UNSIGNED_BYTE, screen->pixels ); ``` Based on the [docs](https://registry.khronos.org/OpenGL-Refpages/gl4/html/glTexSubImage2D.xhtml), the call...

The function [fw_pad](https://github.com/assafshocher/ResizeRight/blob/master/resize_right.py#L386) is supposed to perform a crop when called with negative padding values. However, the numpy codepath raises a ValueError if np.pad() is called with negative values. Specifically,...