Harshit Rajput

Results 14 comments of Harshit Rajput

Hi @jack-berg , isn't `AutoConfigurationCustomizerProvider` already providing this capability of programmatically adding configurations? Eg: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/examples/extension/src/main/java/com/example/javaagent/DemoAutoConfigurationCustomizerProvider.java Although, currently the SPI implementations are configured first before configuring from the file. But I...

@jack-berg you are right, `AutoConfigurationCustomizerProvider` doesn't seem to be a good idea. However, I investigated and explored more in direction of a new spi like `DeclarativeConfigurationCustomizer`. These were my observations/...

Continuing @kilink 's comment https://github.com/Netflix/dgs-framework/issues/1928#issuecomment-2267739883 , I don't think it's a bug in otel java instrumentation either. We know that to pass context in CompletableFuture we need to wrap Executor...

> If I remember correctly, it doesn’t work even if the batch contains only 1 parameter. Doesn't matter if it's 1 or more parameter. It's the DataLoader framework which is...

`ConfigUtil.getString()` uses `System.getProperties()` and `Properties` is not thread safe. Is it possible that your application in some other thread at the same time may be changing `System.Properties` in any way...

@jack-berg how about using ConcurrentHashMap to store a copy of the properties for iteration? also AFAIK static block runs once when the class is loaded. I suppose `DebugConfig.isMetricsDebugEnabled()` in `SourceInfo.fromCurrentStack()`...

True. it gets difficult to explain the users when there is slowness, firewall issues, etc issues in the infra side, if it's not a backend outage. Some kind of documentation...

Any clue why in 'markdown-link-check' job following links are failing: ``` [✖] https://maven-badges.herokuapp.com/maven-central/io.opentelemetry/opentelemetry-api → Status: 503 [✖] https://maven-badges.herokuapp.com/maven-central/io.opentelemetry/opentelemetry-api/badge.svg → Status: 503 ``` How can we fix this?

what should be the metric here - no. of logs (batch size) that failed to get exported or simply failed export occurrence ?

hmm.. i was thinking- the end user should be worried about the export failure occurrence or how many logs failed to get exported. How should it matter whether 1 log...