Harry Whorlow

Results 39 comments of Harry Whorlow

@DiegoAndai coming at you with some fresh hot PR corrections.🤟

@DiegoAndai, morning man! more revisions ready for review🤟 With regards to the question I would forget about it... I can't remember what it was about, plus it was made at...

Morning @DiegoAndai, thanks man! 🤟 I'll look at the task list Monday and pull out the next one, thanks for all the time spent reviewing the code and suggestions.

@DiegoAndai Thanks for the opportunity to contribute, and thanks for taking the time to review my code. Sorry about the docs.... I had read it, but completely forgot.🙃 I hope...

Hi @DiegoAndai thanks again for the code review, as always its appreciated. 🤟 I've made the changes you requested. I'm a little unsure on the tests, so if you could...

Afternoon @DiegoAndai! Thanks for the code review! 🤟(as always) Please find the amended code pushed. A quick point of note, running the tests throws an error, as the describeConformance prop...

Good afternoon @DiegoAndai, I hope you had a good start to the week! Please find my attempt at the codemod pushed! I haven’t had much experience with code mods before,...

@DiegoAndai Good morning man! Hope your having a good start to the week! Please find the updated code so that it's synced with master. I pulled re-based, hence why all...

> Hey @harry-whorlow. Initially I suggested deprecating `transitionDuration` in favor of `slotProps.transition.timeout`, but now I think we can keep `transitionDuration` as it's a common use case so it's easier to...

Afternoon @DiegoAndai, or good morning... I suppose it depends on where you live. If its cool with you, I'll pull rebase to update with main and get rid of the...