material-ui
material-ui copied to clipboard
mui
[material-ui][SpeedDial] Deprecate TransitionComponent
Part of: https://github.com/mui/material-ui/issues/40417
@DiegoAndai here's my submission for the speedDial deprecation of TransitionComponent
Changes made to speedDial component speedDial: Add deprecations for transition props and the slots API that should replace it. speedDial: Updated prototypes and docs
Questions for reviewer I see that this component has tests for the Fade transition should the Fade, in these tests, be passed in slots?
Netlify deploy preview
SpeedDial: parsed: +2.51% , gzip: +2.34%
Bundle size report
Details of bundle changes (Toolpad) Details of bundle changes
Generated by :no_entry_sign: dangerJS against 727c7901f1ce4a154a6a50045a20581a82fee76d
Sorry, I was away for holidays... I'll be picking this up over the coming two weeks.
I wrote two utils that will make the codemods easier for this: https://github.com/mui/material-ui/pull/41685
It should be merged soon, I would recommend waiting for that 🙌🏼
@harry-whorlow, https://github.com/mui/material-ui/pull/41685 was merged. You should be able to merge next into your branch and use the new util so the codemod is easier to implement.
yo @DiegoAndai, hows it going man? I've got another one ready for code review.
Enjoy the weekend! 🤟
@DiegoAndai, comments resolved... Let me know if you have any more requests, enjoy the start to the week🤟
I just noticed your question:
I see that this component has tests for the Fade transition should the Fade, in these tests, be passed in slots?
Which tests are you referring to?
@DiegoAndai, morning man! more revisions ready for review🤟
With regards to the question I would forget about it... I can't remember what it was about, plus it was made at the very start.
Enjoy the weekend!
Morning @DiegoAndai, thanks man! 🤟
I'll look at the task list Monday and pull out the next one, thanks for all the time spent reviewing the code and suggestions.