Harold Treen

Results 83 comments of Harold Treen

What do you mean by this? When you use readability, the article returned will be null if nothing was found. Otherwise it will return whatever part of the article it...

Ah. Interesting. I wasn't aware that iOS did that. Some ideas: - You could look at the metadata to determine if the page is an article. Use that to remove...

This looks like an interesting option @hankliu62 👍 . What do you think about calling it `candidateFilters`? Filters just accept a single candidate, so it makes a bit more sense...

Thanks for the updates @hankliu62 ! Only last thing I would consider is bumping the version in package.json to `3.1.0` to indicate a new feature has been added. Also note...

Looks like it's coming from `parse5`... stack trace doesn't suggest where in `readability` this is getting called... 🤔 . Do you have the `html` you're trying to parse?

This is true. I'll try to remember this, but if anyone is free in the meantime and wants to reduce the image sizes that would be welcomed.

Good point 👍 . I don't have much experiencing wiping things from history, but I'm assuming you can do it with a PR?

My guess is that this `` has the word `link` in it. That could be confusing to readability as links are usually something you want to remove... ![image](https://cloud.githubusercontent.com/assets/1745854/23621079/4f8ceaa0-0267-11e7-8b41-c5a967a28b96.png) See this...

First off, thanks @luin for this awesome library. I've tried a bunch of others and this has been the best 👍. I'm also finding some sites that don't work well....

Also noticing that no blogspot articles work :/ Eg. http://devopsanywhere.blogspot.com/2016/04/what-if-cli-tools-had-restful-apis.html (There's a lot of nested div which goes contrary with looking for shallow blocks of content.)