readability icon indicating copy to clipboard operation
readability copied to clipboard

Published 20 hours ago • verified publisher icon luin

Add candidateFilters option

Open hankliu62 opened this issue 7 years ago • 4 comments

hankliu62 avatar Jun 20 '18 09:06 hankliu62

@luin @haroldtreen Please help review, and give some suggestions, thanks.

hankliu62 avatar Jun 25 '18 01:06 hankliu62

This looks like an interesting option @hankliu62 👍 . What do you think about calling it candidateFilters? Filters just accept a single candidate, so it makes a bit more sense to me.

Curious if @luin has thoughts because I know less about the history of this module 😅 .

haroldtreen avatar Jul 05 '18 16:07 haroldtreen

@haroldtreen, thanks for all your help! I've updated PR according to your instructions. Let me know if I've missed something.

hankliu62 avatar Jul 05 '18 17:07 hankliu62

Thanks for the updates @hankliu62 !

Only last thing I would consider is bumping the version in package.json to 3.1.0 to indicate a new feature has been added. Also note the new feature in CHANGELOG.md.

haroldtreen avatar Jul 08 '18 20:07 haroldtreen