Haren S

Whilst running MacPorts on a Raspberry Pi with an armv7l processor, I noticed that MacPorts set the incorrect `os_arch`. This PR aims to improve MacPorts support on some more architectures...

Set SOURCE_DATE_EPOCH

4

Closes: https://trac.macports.org/ticket/59672 This PR allows base to define the [`SOURCE_DATE_EPOCH`](https://reproducible-builds.org/docs/source-date-epoch/) environment variable to assist with reproducible builds. The value can be manually set in a portfile via the `source_date_epoch` variable....

Set `configure.cxx_stdlib` on Linux

11

See: https://trac.macports.org/ticket/48957 See: https://github.com/macports/macports-ports/pull/14323#discussion_r835618657 This also means one less thing is required in @kencu's [MacPorts Ubuntu guide](https://trac.macports.org/wiki/InstallingMacPortsOnUbuntuLinux): ``` cxx_stdlib libstdc++ # configure.cxx_stdlib is not yet working on Ubuntu, this fills...

See [here](https://en.wikipedia.org/wiki/Payment_card_number) e.g. Company that issued the credit card.

Following from https://github.com/harens/checkdigit/commit/c6f2e581de89e78e19e76b8c5b673f1945cbaf1d, the shell scripts were replaced with a Makefile. It might be useful to somehow document the various attributes that it provides.

Fix PyPi Formatting

1

See [here](https://pypi.org/project/checkdigit/). Currently, a separate README has to be used, since PyPi understandably doesn't like HTML in the rst file. This means that the gif is currently broken, and a...

See [here](https://checkdigit.readthedocs.io/en/latest/_autosummary/checkdigit.html#module-checkdigit) Currently, the short descriptions aren't very descriptive, e.g. ISBN Validation Functions. Maybe it can be improved by saying what it actually is, similar to the wiki first line...

Error handling

1

At the moment, there is very little error handling and defensive programming. Small things such as detecting if there are invalid characters or whether the size is wrong (and then...

Additional Tests

2

Having more tests can never be a bad thing! Tests can be found in the [tests.py](https://github.com/harens/checkdigit/blob/master/tests.py) file. An example would be the following: https://github.com/harens/checkdigit/blob/59c3ee329f4f2f32655a78a12ba55476f8d636d7/tests.py#L64 The first parameter of `test` is...

Function `missing` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. https://codeclimate.com/github/harens/checkdigit/checkdigit/isbn.py#issue_5fc23e4529cddf000100001f