Miloš Prchlík
Miloš Prchlík
> It looks like this PR also fixes the #3032. Hm, yes and no. Yes, I think this PR might fix #3032, because the plugin and tmt will now use...
Assuming @falconizmi was not available on such late notice on Friday afternoon, I tried to address the comments above. I think there will be failed tests, I'll check them in...
~~And before the merge, $SUBJ & commit message should be updated - it's not fixing "outside fmf root" issue, it's fixing "feature can't run its own playbooks".~~ Done.
@dav-pascual hello, do you still plan to dedicate some of your time to work on this issue?
Seems to be more complicated: * `clean` subcommands do accept `--workdir-path`, and use it, see https://github.com/teemtee/tmt/blob/main/tmt/cli.py#L1861 * `clean` subcommands seem to not use `effective_workdir_root`, https://github.com/teemtee/tmt/blob/main/tmt/utils.py#L254, i.e. they don't obey a...
> The thing is that actually we don't have any plan result implemented. There are only `results.yaml` and based on them the appropriate exit code is reported. That is slightly...
> On the other hand, I'm thinking, whether it would not be more natural for user to state the expected empty plan result as `pass`, `fail`... instead of specifying the...
I don't understand the changes either, that's why I'm hoping smarter reviewers would take a look... But I think we do need full tests in any case.
/packit build
/packit build