Han-Wen Nienhuys

Results 206 comments of Han-Wen Nienhuys

``` fetchPacketSize := d.fetchMaxPacketSize() data := make([]byte, fetchPacketSize) h := &usbBulkHeader{} rest, err := d.fetchPacket(data[:], h) ... func (d *Device) fetchPacket(dest []byte, header *usbBulkHeader) (rest []byte, err error) { n,...

I assume there was some error before the crash that caused the USB connection to break before.

``` # on 2022-10-24T19:07:00+02:00, elapsed 9m1.652261737s: t0002-gitfile.sh - error: # failed 2 among 14 test(s) t0033-debug.sh - error: # failed 3 among 6 test(s) t0410-partial-clone.sh - error: # failed 2...

> async & blocking negotiation of commits AFAIK push doesn't do negotiation? Server just sends a list of sha1s it has and then its up to the client to omit...

I don't have plans, but will happily review a patch if someone produces it.

I can understand that a lock file can be left behind every once in a while, but does it have to take so long to detect? ``` $ time jj...

> If the file is there because another process is currently snapshotting or updating the working copy, then we want to give that process at least a few seconds to...

this is the first time I hear of this. Some notes to myself: * similar in scope to NFS, but don´t need to support multiple simultaneous clients and can use...

> Inode.Forgotten() to detect when Inos can be reused. I would have to think this through in depth to double-check, but Forgotten() is intended for enabling cleanup in a scenario...