go-fuse uses FUSE 7.8 on macOS, while OSXFUSE only accepts invalidations when requesting 7.12 or higher

[EdSchouten]

During handshaking, OSXFUSE announces protocol version 7.19. go-fuse, however, negotiates to version 7.8 instead (_OUR_MINOR_VERSION == 8). This is inconvenient, as support for sending invalidation requests is only part of protocol versions 7.12 and later. OSXFUSE is pretty strict about that, denying any invalidation requests when negotiating to an older protocol version with error EINVAL.

Experience has shown that it's safe to bump _MINIMUM_MINOR_VERSION and _OUR_MINOR_VERSION to 12, as long as the following structures are updated as well:

• Attr
• GetAttrIn
• OpenIn
• MknodIn
• ReadIn
• WriteIn

Doing so also has the advantage of making the programming experience of go-fuse more consistent between Linux and macOS, as it brings the structure layouts closer in sync.

[hanwen]

what does "as long as the following structures are updated as well:" mean ?

[EdSchouten]

Between protocol version 7.8 and 7.12, support for a couple of new features as added:

• Block sizes
• GetAttr calls with dedicated file handle values
• Create with umask
• File locks

[hanwen]

i don't have a mac. I'd be grateful if you could contribute a change

[Jille]

@SnoozeThis https://github.com/hanwen/go-fuse/pull/427

[SnoozeThis]

(https://snoozeth.is/5IEmjmYIfW0) I will wait until https://github.com/hanwen/go-fuse/pull/427 is merged and then add a comment.

[SnoozeThis]

An error occurred while snoozing: Pull request was closed without being merged

[hanwen]

this was fixed with bf8e510474e49a47cd278f0d885ecc86badbd947