Hanno Braun

Results 489 comments of Hanno Braun

Thank you for your feedback, @calmofthestorm. I'm very open to improving the situation and make your use case possible, but I think allowing users to clone `Inotify` would be taking...

Fully agreed! I've opened https://github.com/hannobraun/inotify-rs/issues/176 and https://github.com/hannobraun/inotify-rs/issues/177 to track the improvements we talked about here. Any help in implementing them is very welcome. I don't have much time to work...

Thank you for opening this issue, @i509VCB. I'm all for that! It's just an issue of someone doing the work, i.e. adding Clippy to the CI build and fixing the...

Hi @i509VCB, thank you for your pull requests! I'm currently on vacation, but I'll be back next week and will take a look then (or maybe the week after, if...

#179 has been merged, which is a partial resolution to this issue.

Thank you for looking into this, @talklittle! I've looked at the documentation of `ToOwned`, and I believe you're right: the trait doesn't fit `Event`, and the existing `to_owned` method should...

I just had this thought regarding this issue: The current test suite covers the basics, assuming that anything not explicitely covered will work fine, since we don't do anything fance...

Another tought: I think it would be better to model event queue overflows as an error, not just another kind of event.

Additional thoughts: - The `cookie` could be removed. Instead it could be added as a field to the rename event variants of the `EventKind` enum. Then an `Eq` implementation or...

Thank you for reporting!