Erlend Hamnaberg comments

Results 119 comments of


                                            Erlend Hamnaberg

Update TODO list

Maybe the todo-list should be converted into issues?

Improve support for URI parts in namespaces

+1. This is a very annoying problem when using lots of namespaces. I am building an [atom library for Scala](https://github.com/arktekk/scala-atom/) using anti-xml.

Always remove subscriber from pipeline when completing a reactive stream

might be related to #1660

Always remove subscriber from pipeline when completing a reactive stream

this was not enough to fix the issue, seems like something is broken in either the reactive streams handling or the use in http4s.

It is really difficult to create an unfiltered.netty server that chunks

The server should not be a case class, and be parameterized on PortBindings. Would you still be intereststed in a PR for this?

Params.unapply missing explicit type, doesn't compose, and has lying docs

We cant change how Params work now, but we could add a `ChainableParams` extractor or something like that to enable this. Otherwise I would recommend using `unfiltered-directives` to chain this...

Move/delete non-core modules

@softprops Which specific modules are you referring to? The initial list of non-core modules I think is: - mac - oauth - oauth2 - json4s Maybe: - agents - websockets

Refreshing SSL contexts on the fly

Something like this might work: https://gist.github.com/hamnis/3a2a30d136f7016b71ca16a5e443a179

CORS headers aren't added to failed requests

This is because you are ending up in the global error handling and CORS is implemented as a middleware. The global error handler is not part of the normal chain....

0.23 -- URI equality bug: `uri"/".addSegment("Test").addSegment("") != uri"/Test/"`; values are not equal even if they have the same `toString()`

these are not the same which is expected. The implementation of Uri.Path is taking into account if the path ends with a slash. the equals method does check for this....