Hamish Willee

Results 1524 comments of Hamish Willee
trafficstars

> A "removal-date" attribute on deprecated would seem to be a good future addition to give people a count-down :-) https://github.com/ArduPilot/pymavlink/pull/1144

I'll look at this tomorrow too. @dk7xe Best to get this as complete as possible so you don't have to come back to it, or at least not for ages.

@valbv Sorry, have reject review - I don't know enough about code to do it safely. This is back to @mrpollo ... or @dakejahl

@mrpollo I don't know enough about driver code to give this a technical review. If you do then great, but otherwise is there a technical reviewer we can ask?

@valbv Thanks for for that. Looks great. I'm approving for the docs/general sanity part, but I don't merge code. @mrpollo YOu requested @dagar look at this in May: https://github.com/PX4/PX4-Autopilot/pull/24824#pullrequestreview-2844719537 -...

I like this a lot. A few comments/nits inline. 1. Clicking-jacking and XSS and the upgrade stuff sections should be linked from respective docs that mention them - e.g. glossaries....

I've been through it again. REsolved the issues that I think have been addressed. Really like the new structure for the [XSS and resource loading](https://pr36157.content.dev.mdn.mozit.cloud/en-US/docs/Web/HTTP/CSP#xss_and_resource_loading) - meets the goals of...

A few more ``` [05:58:02|Debug] MAVLink: emergency: Accel #0 fail: TOUT! (device_impl.cpp:223) [05:58:02|Debug] MAVLink: emergency: Gyro #0 fail: TOUT! (device_impl.cpp:223) ```

When this is ready can we please have some docs. Specifically and addition to https://docs.px4.io/main/en/sim_gazebo_gz/vehicles.html and to the list here: https://docs.px4.io/main/en/sim_gazebo_gz/#running-the-simulation Also in https://docs.px4.io/main/en/sim_gazebo_gz/ a new section "Simulating a Gimbal"...

This is very nice!! Note, we need to make sure these things are documented. Feature parity also means "works out of the box", not "we added a distance sensor to...