Hamish Willee
Hamish Willee
Thank you for this - sorry I'm late to review. There is a more comprehensive update to this document in https://github.com/mdn/content/pull/35353 I think we'll merge that, and then @bsmth can...
@bc-lee FYI @Josh-Cena is correct - the fact that the spec mentions these dictionaries is irrelevant. Specs are written for browser developers, while MDN interprets the specification for webapp developers....
It's definitely non standard - updated in BCD here https://github.com/mdn/browser-compat-data/pull/24442 These fixes are good, but I worry that they will cause problems with the auto-update tooling when the BCD changes...
A bunch of mostly nits.
@bsmth Just nits now. Approved so you can self-merge after looking at them.
@dipikabh Aside from https://github.com/mdn/content/pull/34725#discussion_r1751312240 I think this is pretty good. If you compare https://pr34725.content.dev.mdn.mozit.cloud/en-US/docs/Web/Manifest/icons with the original https://developer.mozilla.org/en-US/docs/Web/Manifest/icons you can see that the old way was "prettier" but this contains...
New structure looks good to me. I added a few comments/suggestions. The most important is https://github.com/mdn/content/pull/34725/files#r1759389846
> @estelle Most glossary entries I've seen use the abbreviation as the title. I assume one of the original intents of the glossary was to search for abbreviations and see...
@estelle Were you planning on doing this work. I could take it on as part of #31971 but it sounds like you have a grip on what you want.
I'm asking about support for the MP4v format in https://bugzilla.mozilla.org/show_bug.cgi?id=1427278#c5 - it seems likely that you're right, but want to be sure.