Hamish Willee

Results 1531 comments of Hamish Willee

@chfriedrich98 I think this structure looks excellent. Its good to see common flight modes. I adopted the v1 and v2 naming because it is rarely a good idea to refer...

As the wording is now "Positive values are positive thrust, negative values are negative thrust.". That implies that on a vehicle with only positive thrust you have to have a...

> Turns out that MissionPlanner actually already does what you're suggesting here - makes mavlink calls rather than passing through the button bits (a small impediment to my little project)....

@peterbarker There was an orthogonal discussion here https://github.com/mavlink/mavlink/pull/1848 which looks at the use case of a MAVLink joystick. This is a joystick that does not need to be connected to...

Anyway, appreciate that you're probably making a pragmatic decision based on what mission planner does now (and PX4). Nothing is going to change in any sort of short timeframe so...

Discussed this in the [20250410](https://github.com/mavlink/mavlink/wiki/20250410-Dev-Meeting) dev call. This was explained to me as follows (capturing so I don't have to ask this all again!) 1. [`MANUAL CONTROL`](https://mavlink.io/en/messages/common.html#MANUAL_CONTROL) is defined as...

The issue in node 12 test is the use of `descriptor?.isOwn` - the optional chaining operator appears first in node 14 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining We should drop that. Not sure about the...

@julianoes Any ideas on the Node 14 failure? Copied from [here](https://github.com/mavlink/mavlink/actions/runs/6179806789/job/16775320760?pr=2039) (starting from first error): Merged enum MAV_CMD Merged enum MAV_CMD Merged enum MAV_CMD Merged enum MAV_CMD ERROR: Duplicate enum...

> PR https://github.com/mavlink/mavlink/pull/2041 is also failing Node 16. Yeah, but for whatever reason this did fix node 14! I've added 15, 17 to that PR too to see if it...

HOld on, I wonder if the 14 error is caused by ``` ERROR: Duplicate enum names: SPEED_TYPE.SPEED_TYPE_AIRSPEED = 0 @ /home/runner/work/mavlink/mavlink/message_definitions/v1.0/common.xml:3464 SPEED_TYPE.SPEED_TYPE_AIRSPEED = 0 @ /home/runner/work/mavlink/mavlink/message_definitions/v1.0/ardupilotmega.xml:27 ``` We just added...