Peter Hunt

Results 616 comments of Peter Hunt

/approve thank you for your patience and time @LenkaSeg !

yeah for this one I'd be fine just adding ones that are within style guidelines, marking the others as deprecated. I don't think we need a config field like we...

/hold it's my preference not to revert. I think there are potentially some other avenues we can explore first

Intersting idea! setting an inotify on the registry paths could work. Something to note: in the past, I have heard hesitation about updating registries without a drain/reboot because it hides...

@phillebaba agreed! I think the delayed failure on incorrect value is the trouble. That said, it would end up being delayed with a reboot and `IfNotPresent` or `Never` pull policies...

I think this would be better added to the code already i n https://github.com/cri-o/cri-o/blob/main/internal/oci/container.go#L530-L540 or more precisely https://github.com/cri-o/cri-o/blob/main/internal/oci/container_linux.go#L53

sorry I may not have been clear. Queries to /proc are not trivially cheap and I think we should consolidate reading from /proc/pid/status if possible. We're already reading the start...