Peter Hunt

@klihub the reasoning behind the NRI errors aren't clear to me, can you help me find the issue?

I'd like to use this PR to note some oddness about the high performance PreStop hooks: they run at different times depending on how the container stops. If it stops...

thanks @klihub applied the patch

rebased, PTAL @cri-o/cri-o-maintainers

hm still failing /hold

sorry for the delay @rmt! I think having an option in cri-o to not sync the log makes sense to me. I don't think we can make it the default...

I see your point, and I agree! I think long term we can consider having fsync off by default. I think it should begin configurable, and start off as on...

I did a bit more digging. I haven't found details about the exact reason we made the behavior configurable in conmon, but I did find the release notes of https://github.com/containers/conmon/releases/tag/v2.0.20...

you need a special go compiler to enable FIPs mode in CRI-O: https://github.com/cri-o/cri-o/issues/5256#issuecomment-909756678

@lsm5 and @mrunalp were the people that did the work getting fips mode together.