Đỗ Trọng Hải

Results 41 comments of Đỗ Trọng Hải

can you check if `grafana/agent` image can be pulled into your cluster to be operational? Some pod logs would be helpful :D

> It looks like 55 targets are graphed in this 3 hour window. So almost 1/3rd of my pods. That seems excessive. > > on second thought, is this feature...

@TheRealNoob @mattdurham thank you for the feedback! I've made the corrections accordingly. Btw, re: building a Agent's image, I'd suggest using `make agent-image` :D (at least that's what I've been...

thanks @TheRealNoob for the testing and findings! I've done all items you've found to reflect them :D Once again, thanks 🙏

@microsoft-github-policy-service agree

CMIIW but the `pyroscope.scrape` component seems to allow defining custom paths for each `pprof`endpoint For example, [`profile.goroutine` block](https://grafana.com/docs/agent/v0.39/flow/reference/components/pyroscope.scrape/#profilegoroutine-block) Me thinks we can remove it :D

While it's tedious to do the override but I think that gives a more granular control to the users. In addition, they don't need to check other options that would...

> Thanks for the PR. Can you add Testing Done section, especially testing around verifying the CPU variable is correct? Sure, I'll try get the cluster up and running for...

I could tackle this. Please help assign 😄

Aight, thanks for the heads up! I'll try making a PoC to gauge feedbacks firstly then. Maybe not assign me that early 🤭