retina icon indicating copy to clipboard operation
retina copied to clipboard

feat(plugin/packetparser): identify CPU as Flow metadata

Open hainenber opened this issue 3 months ago • 2 comments

Description

Add CPU number as Flow metadata

Related Issue

Closes #94

Checklist

  • [x] I have read the contributing documentation.
  • [x] I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • [x] I have correctly attributed the author(s) of the code.
  • [ ] I have tested the changes locally.
  • [ ] I have followed the project's style guidelines.
  • [ ] I have updated the documentation, if necessary.
  • [x] I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

hainenber avatar Apr 07 '24 12:04 hainenber

Thanks for the PR. Can you add Testing Done section, especially testing around verifying the CPU variable is correct?

Sure, I'll try get the cluster up and running for a proper E2E test. I was thinking that unit test would be sufficient 😅

hainenber avatar Apr 07 '24 14:04 hainenber