Timothy Sweetser
Timothy Sweetser
Per https://docs.python-guide.org/writing/logging/, best practice is to add a null handler.
The model object includes lots of bloat, e.g the full training data. It would be nice to serialize a minimal version containing only that which is necessary to make predictions....
I think we use the full variety of Python 2+3 compatible string formatting methods. It might be cleaner to pick one and stick with it.
Currently, fitting the model modifies the training data frame in place when copy=False. I think we can improve the manners here. 1. Remove the columns created: `row_index` and `intercept` 2....
```python import pickle import numpy as np import pandas as pd from ibex.sklearn.preprocessing import Imputer from pandas.testing import assert_frame_equal df_in = pd.DataFrame({'x': [1, np.nan, 3]}) expected_output = pd.DataFrame({'x': [1., 2.,...