Markus D. Herrmann
Markus D. Herrmann
@pieper I have Typescript type declarations for parts of the library, which I would be happy to share/add and which we could build on.
Great! @WoonchanCho I have type annoations for the `sr` subpackage. We could then start from there. I will prepare a pull request.
@WoonchanCho I have a type declarations file. It's not yet complete and I have yet tested its distribution via the npm. I will push what I have and then we...
@pieper @emelalkim the classes in [dcmjs.sr.templates](https://github.com/dcmjs-org/dcmjs/blob/c8fba616e53e36db4cd80f7c334580490898c4f7/src/sr/templates.js) should support that in principle. These are pretty much a 1-1 translation of the `highdicom` implementation. However, not all parts may have been extensively...
The fact that `pydicom.sequence.Sequence` inherits from `pydicom.multivalue.MultiValue` seems to be quite problematic. The former should be `Sequence[pydicom.dataset.Dataset]` while the latter should be `Sequence[pydicom.dataelem.DataElement]`. This seems to be difficult to achieve...
> Shouldn't it be MutableSequence[T]? A VM > 1 DataElement's value is a MultiValue instance. Yes, you are right. It's of course only the Data Element's value. Note, however, that...
I think including the version of the standard is a good idea. Personally, I would not only put this in ``_dicom_dict.py`` and ``_snomed_dict.py`` but keep it at the package root...
@WoonchanCho The `sr` namespace should be relatively completely. The `data` namespace is partially complete. All other parts of the package are still missing. Feel free to add additional type declarations...
> Let's be sure to give the final PR commit line a semantic versioning prefix like feat(typescript) so it'll auto deploy to npm. Cool, I was not aware of this...
Note that this feature requires Pillow, which is an optional dependency.