Markus D. Herrmann

Results 256 comments of Markus D. Herrmann

Hey guys, I ended up implementing this functionality using [Ansible cloud modules](http://docs.ansible.com/ansible/list_of_cloud_modules.html). These modules allow launching/terminating instances using various cloud providers, but also make it easy to manage security groups,...

Thanks for your feedback @nazrulworld. It seems version 6 introduced several breaking API changes. You have listed three in the README, but it would be great if you could document...

It may also be a good idea to check for `0xE8` ("APP8" segment) to further distinguish SPIFF from baseline JPEG.

> trailing underscore will be shown by dir() and autocomplete, so perhaps that is a better solution. Yes, I was hoping that a trailing underscore will be intuitive to use....

> Re my comment on metadata, I wonder if there is a way to integrate this into Dataset - just off the cuff here, could we have something like a...

@darcymason not sure whether you noticed the color correction feature (see [here](https://github.com/hackermd/pydicom/blob/e1056bd16e193cfd8495cf2e9f690d9fe03cc5a4/pydicom/filereader.py#L1592-L1615)), which depends on https://github.com/pydicom/pydicom/pull/1446. This feature is potentially a bit tricky, because it requires Pillow. We could also...

> > Not every Dataset actually represents an image and I therefore find adding more image-specific methods to the class problematic. > I generally agree very much with avoiding image-specific...

> > Efficient frame-level access would require setting stop_before_pixels to True when using pydicom.fileread.dcmread() to read the data set from a file > This had crossed my mind, but I...

@darcymason I removed the color management code from the `ImageFileReader` for now, since it depends on #1446, which is probably more WIP than MRG at this point (I updated the...