Augusto Hack

Results 91 comments of Augusto Hack

If we are going to track how the stack changes, it would also be nice to allow giving the position names (shameless plug https://github.com/0xPolygonMiden/miden-vm/issues/638 :) )

Created the issue for const vales: https://github.com/0xPolygonMiden/miden-vm/issues/634

IMO we should support multi-line input, so that one can copy and paste the procedure from a file.

> If I understood correctly, this would be like reading the offset off the top of the stack My suggestion would have no impact on the binary representation or runtime,...

Suppose we have a small piece of code to load data from memory and add one to the first element of the word: ``` push.1 padw push.1000 loadw movup.4 add...

Hey @gdippolito , thank you for the request. We are aware of it and will add your request to our backlog. If you would like contributions are also welcome :)

I opened this issue because the withdraw failed on a test from @taleldayekh , but we can force an error to test the UI if necessary.

> Is it correct to think this never happens in practice today, and we should re-evaluate this only when Raiden implements multi-transfer payments? As of `raiden==1.1.1` yes, the related issue...

> What do you mean? So SecretRegistry's constructor will register the hash of the address of itself? The `TokenNetworkRegistry` constructor should validate that the [address provided](https://github.com/raiden-network/raiden-contracts/blob/94f1428d2fad4719efffb26be3d7731d7bb3f3da/raiden_contracts/data/source/raiden/TokenNetworkRegistry.sol#L42) is a valid secret...

> Especially, what registers the SecretRegistry and what queries the registered block. That was just a suggestion, any random value that is not registered yet can be used.