webui
webui copied to clipboard
raiden-network
Webui should show a popup if a withdraw fails
Abstract
Inform the user when a withdraw fails.
Motivation
Usability.
Specification
A withdraw may fail if the partner node doesn't send the withdraw confirmation message. This can happen if the partner is uncooperative, if there are network problems, etc. To help the user understand what happen the webui must show a popup with an error message.
@hackaugusto does this require any change on the API? if not maybe this issue should be moved to the WebUI repo
A failure in withdraw will return 400 or 409 so i don't think any API changes are required here. Transferring this issue to the WebUI repo.
If there is an error returned from the API then I don't think there is anything to be done on the WebUI. The WebUI should display an error message if a request fails for any reason.
The WebUI already shows a popup for every error returned from the API. @hackaugusto Did you encounter that this was not the case for a failing withdraw?
I opened this issue because the withdraw failed on a test from @taleldayekh , but we can force an error to test the UI if necessary.
If the api properly returns an http error code then an errors should be shown. Try again an let us know.
On Wed, Sep 4, 2019, 10:12 PM Augusto Hack [email protected] wrote:
I open this issue because the withdraw failed on a test from @taleldayekh https://github.com/taleldayekh , but we can force an error to test the UI if necessary.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/raiden-network/webui/issues/148?email_source=notifications&email_token=AARKEJEUR2G3YSN7LTYWDNTQIACDPA5CNFSM4ISMUBD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD54U3XQ#issuecomment-528043486, or mute the thread https://github.com/notifications/unsubscribe-auth/AARKEJCVDZT2GA77PVBILXDQIACDPANCNFSM4ISMUBDQ .
I tested the withdraw with an offline channel partner and for me the WebUI shows a Timeout error, which means that the API did not respond after 10 minutes. @hackaugusto After what time would the API return an error in case of an uncooperative channel partner?
Having a blocking http request for 10 minutes is already bad. Any safe expiry time would probably be way more than 10 minutes. We need a better way to retrieve statuses than blocking.