Augusto Hack

Results 40 comments of Augusto Hack

@blueyed thanks for the reply. I believe `get_coro` doesn't work with more complicated code, example: ```python async def f(): async with aiohttp.ClientSession() as session: async with session.get('http://python.org') as response: html...

ATM for schema registry the communication is performed using just HTTP. Reference: https://github.com/aiven/karapace/blob/3cd4769e2fafdfd9baf6c9dfec450d32ec08ab16/karapace/master_coordinator.py#L173

I'm hijacking this issue. Renaming it from a question to a suggestion.

@YuWang24 it would be nice to know why you were searching for this feature. Do you have nodes communicating over the public internet?

@YuWang24 , `StatsClient` is a class that can publish metrics using the [statsd](https://github.com/statsd/statsd) format and send tracebacks to sentry. But as you noticed there are not that many metrics being...

@alpreu currently we are not working on this feature. PRs are welcome :)

> Question to @hackaugusto or @lornajane - Can the PRs be conducted in official Aiven’s Karapace GitHub repository instead of Instaclustr's fork? Should be fine as long as the tests...

Ping @tvainika @juha-aiven @jjaakola-aiven

Hi @sujayinstaclustr, no worries. @jjaakola-aiven is doing the review :)

`SIGINT` and `SIGTERM` are handled by default: https://github.com/aio-libs/aiohttp/blob/v3.7.1/aiohttp/web_runner.py#L269-L270 https://github.com/aio-libs/aiohttp/blob/v3.7.1/aiohttp/web.py#L474 This should be sufficient for a clean shut-down as long as there are no web-sockets: https://docs.aiohttp.org/en/stable/web_advanced.html#graceful-shutdown