Phil Haack
Phil Haack
@hoppybunny let me know if you can get to this or I can take over. Thanks!
@hoppybunny I took care of it. It turns out your fix for $autocapture events wasn't correct. This is one reason I like a PR per issue. Makes it easy to...
These fixes were committed in other PRs.
Ugh, `test_flag_matching.rs` is so huge. I wanted to refactor it to use sub mods to group tests so they were a bit more organized (like I did with `test_graph_utils.rs`, but...
I had a similar problem. It turned out that while I updated all the aspire libraries in my solution to 8.1.0, I hadn't updated the workload. ```bash dotnet workload update...
> This means a ton of potential overloads to create (and maintain). Maybe making some optional parameters less optional should be considered as well. Given this is a library, I'd...
> So my advice would be to bump the major version with reckless abandon - because that's how it should be! If you're changing the public API surface - and...
I think the greptile comments are worth addressing. Otherwise, the changes look good to me!
> What if we go about it this way - only allow this key type (SDK naming TBC) on specific actions that make our customers' apps run, i.e. endpoint execution,...
> @haacked Are we cool to go with this as the first step without breaking feature flags in any way, especially considering your Rust implementation. Let me take a look....