Phil Haack comments

Results 132 comments of


                                            Phil Haack

Containerized action workspace directories seems to be rewritten on-the-fly

I got it working in my case. It was confusing because I couldn't find any documentation of the `/github/workspace` path. It's not mentioned anywhere. So when my containerized action said...

Add a markdown Tag Helper

I have a markdown tag helper I wrote that doesn't do the `src` thing, but it does allow sanitized inline HTML (via an `allow-html` attribute). It also supports a `normalize-whitespace`...

Add a markdown Tag Helper

https://github.com/DamianEdwards/TagHelperPack/pull/46 Done!

Idle

So if I understand correctly, this is in a loop within the console, right? In that case, I don't see any reason to change this code. You generally want to...

Do not validate immediately

Was this addressed in #110?

getFeatureFlagPayload doesn't trigger $feature_flag_called

@marandaneto yeah, looks like the flutter library isn't emitting the event in this scenario the same way that the other client SDKs do.

fix(cohort): When exporting in cohort edit, add support for file name mapped to cohort's name

Thanks @lshaowei18. I rebased your PR into a new PR so the CI runs properly. See #34101

fix(cohorts): deleting cohort with 'not in cohort' filter in a cohort list

Hi! I don't think this is the correct solution as it removes the ability to "undo" the delete. Normally, when you delete, there's a toast at the bottom with a...

fix(cohorts): deleting cohort with 'not in cohort' filter in a cohort list

> I suspect it's because createCohortFormData returns a FormData object and deleteWithUndo spreads the object into a JSON payload and won't serialize as expected? Yeah, I think the other PR...

fix(cohorts): deleting cohort with 'not in cohort' filter in a cohort list

@hoppybunny Great job! The delete code is perfect. Would you mind moving the fix for #32599 into a separate pull request so I can review that separately.