posthog icon indicating copy to clipboard operation
posthog copied to clipboard

fix(ci): skip permissioned workflows on external PRs

Open thmsobrmlr opened this issue 6 months ago â€ĸ 1 comments

Problem

After https://github.com/PostHog/posthog/pull/33717, external PRs can be merged again. However there are still some failing workflows, see: https://github.com/PostHog/posthog/pull/33576

Changes

Adapts the config to skip them on external PRs.

How did you test this code?

CI run

thmsobrmlr avatar Jun 16 '25 10:06 thmsobrmlr

Size Change: 0 B

Total Size: 2.58 MB

â„šī¸ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.58 MB

compressed-size-action

github-actions[bot] avatar Jun 16 '25 11:06 github-actions[bot]

I think the greptile comments are worth addressing. Otherwise, the changes look good to me!

haacked avatar Jun 16 '25 16:06 haacked

I think the greptile comments are worth addressing. Otherwise, the changes look good to me!

Agree. Done!

thmsobrmlr avatar Jun 17 '25 09:06 thmsobrmlr

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Jun 17 '25 09:06 posthog-bot

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

[!CAUTION]

Detected flapping snapshots

These snapshots have auto-updated more than once since the last human commit:

  • scenes-app-insights-funnels--funnel-top-to-bottom-breakdown-edit--light.png (chromium, shard 2)

The flippy-flappies are deadly and must be fixed ASAP. They're productivity killers. Run pnpm storybook locally and make the fix now. (Often, the cause is ResizeObserver being used instead of the better CSS container queries.)

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Jun 17 '25 10:06 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

[!CAUTION]

Detected flapping snapshots

These snapshots have auto-updated more than once since the last human commit:

  • scenes-app-insights-funnels--funnel-top-to-bottom-breakdown--light.png (chromium, shard 2)

The flippy-flappies are deadly and must be fixed ASAP. They're productivity killers. Run pnpm storybook locally and make the fix now. (Often, the cause is ResizeObserver being used instead of the better CSS container queries.)

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Jun 17 '25 10:06 posthog-bot