posthog icon indicating copy to clipboard operation
posthog copied to clipboard

fix(cohort): When exporting in cohort edit, add support for file name mapped to cohort's name

Open lshaowei18 opened this issue 7 months ago • 2 comments

[!IMPORTANT] 👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Problem

Related to #32618

Changes

https://github.com/user-attachments/assets/f4f79d02-0320-4701-b7f3-2ff15fd3c001

Feel free to suggest any better approaches! It seems like the Query component is used in various places, so adding a new property to the query context might not be the best solution.

Did you write or update any docs for this change?

  • [ ] I've added or updated the docs
  • [ ] I've reached out for help from the docs team
  • [x] No docs needed for this change

How did you test this code?

Tested in localhost!

lshaowei18 avatar May 24 '25 10:05 lshaowei18

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

posthog-bot avatar Jun 02 '25 07:06 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

posthog-bot avatar Jun 16 '25 07:06 posthog-bot

Thanks @lshaowei18. I rebased your PR into a new PR so the CI runs properly. See #34101

haacked avatar Jun 24 '25 16:06 haacked

Thanks @lshaowei18. I rebased your PR into a new PR so the CI runs properly. See #34101

Thanks :)

lshaowei18 avatar Jun 25 '25 00:06 lshaowei18