Ryan Powell
Ryan Powell
I need some time to test/review this further but it looks great so far.
I think we should move this outside of `NimBLEUtils` because this code should either belong to the client class or it's own remote attribute class so that it can be...
Instead of inheriting I think we should just add it to a header file `NimBLERemoteGattUtils.h`
The P4 build errors are not caused by this PR, upstream issue. Please add `fail-fast: false` here: https://github.com/h2zero/esp-nimble-cpp/blob/8158a16fbf3d716fd2dd16f6f8990c12265aefe7/.github/workflows/build.yml#L15
Nice, all looks good to consolidate. I think we should communicate offsite, if you're interested please contact me through the email in my profile.
I'd love to but I'm not sure how, the duplicate config is required for the p4 to enable Bluetooth.
I don't think this a an issue for espressif either, it's just the way the kconfig works and is caused by this: https://github.com/h2zero/esp-nimble-cpp/blob/25af28bcad1d3c42f76bfc6e73bea3f833a4ef6d/Kconfig#L211
This could work but you would have to register callbacks for handling lots of things and probably in a correct order, not really recommended. Instead I can point you to...
@gkoh Looks like espressif added this back after it was removed years ago, https://github.com/espressif/esp-nimble/pull/7 I will look to remove this here, again, for now I suggest you comment that section...
What happens if you disable the privacy config, just edit the file? Bluetooth classic has been deprecated for a few years now by the SIG so nobody is making chips...